Grow size faster with a small number of tests #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not useful with `recheckAt`, and makes fast growth more awkward to implement. This might break compatibility more than upstream wants, but at this point I've mostly given up on getting things merged there. If they do want fast growth we can figure out something.
Closes hedgehogqa#472. We now grow test size in fixed increments from 0 to 99, or as close as we can without going over, in however many tests we run. If we run more than n * 100 tests, then we go from 0 to 99 n times, and then do fixed increments for the remainder. Additionally, if we discard a bunch of times in a row we start to grow the size.
They're ignored, but this means hspec-hedgohog works again. Also, there was a parameter named `size` that should have been named `seed`.
|
Merging because we've been using this in excelsior for a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in hedgehogqa#472. We now grow test size in fixed increments from 0 to 99, or as close as we can without going over, in however many tests we run. If we run more than n * 100 tests, then we go from 0 to 99 n times, and then do fixed increments for the remainder. Additionally, if we discard a bunch of times in a row we start to grow the size.
This will be helpful for https://github.com/proda-ai/excelsior/pull/8811, where currently we do 10 tests at a time and use ranges that would be larger than intended if we did more. We'll want to update stack.yaml to use this, and narrow the ranges we specify.
I've removed
recheckbecause "specify the starting size" doesn't really make sense with this, and that function is no longer suggested by failure reports. If upstream wants to keep it for backwards compatibility we can figure something out.Upstream PR is hedgehogqa#474.