Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/69 설문 미리보기 기능 추가 #76

Merged
merged 4 commits into from
Aug 27, 2024
Merged

feature/69 설문 미리보기 기능 추가 #76

merged 4 commits into from
Aug 27, 2024

Conversation

joseph0926
Copy link
Contributor

@joseph0926 joseph0926 commented Aug 27, 2024

PR 유형

어떤 변경사항인지 체크해주세요 (중복 체크 가능)

  • 버그 (bug)
  • 기능 (feat)
  • 수정 (fix)
  • 리팩토링 (개선 느낌) (refactor)
  • 문서 (docs)
  • 기타

PR 설명

  • 설문 미리보기 기능 추가

관련 이슈

스크린샷

체크리스트

  • 코드가 정상적으로 컴파일되고 모든 테스트를 통과했습니다
  • 변경사항에 대한 테스트를 추가했습니다 (버그 수정 / 기능 추가의 경우)
  • 관련 문서를 업데이트했습니다

추가 정보

@joseph0926 joseph0926 self-assigned this Aug 27, 2024
@joseph0926 joseph0926 linked an issue Aug 27, 2024 that may be closed by this pull request
@@ -45,6 +44,18 @@ export const CreateSurveyPageStep1 = () => {
});

const submitHandler = (values: CreateEventType) => {
sessionStorage.setItem(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

localstorage가 아닌 세션에 저장하시는 이유를 여쭤봐도 될까요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아뇨 별다른 이유가 없습니다
로컬스토리지가 나을까요??

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아뇨 상관없을것 같습니다

저는 항상 로컬스토리지만 사용했었어서요!

@joseph0926 joseph0926 merged commit 0fcfb00 into dev Aug 27, 2024
2 checks passed
@joseph0926 joseph0926 deleted the feature/69 branch August 27, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] 설문 미리보기 기능 구현
2 participants