Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catty 718 support bricks in multiple categories #1829

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Catty 718 support bricks in multiple categories #1829

wants to merge 1 commit into from

Conversation

lucatp
Copy link
Contributor

@lucatp lucatp commented Aug 17, 2023

https://jira.catrob.at/browse/CATTY-718

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Verify that the Jira ticket is in the status Ready for Development
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s git workflow (rebase and squash your commits)
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the #catty Slack channel and ask for a code reviewer

@lucatp lucatp requested a review from wallisch August 17, 2023 14:01
@lucatp
CATTY-718 Support Bricks in multiple categories
3c769ec 
Adjusted first bricks to changed Protocol to allow a brick to be in multiple categories.

CATTY-718 Support Bricks in multiple categories

Assigned Bricks to multiple categories like already implemented in the android version

CATTY-718 Support Bricks in multiple categories

Assigning blocks to multiple categories now possible. Todo assign them to the right categories.
@lucatp lucatp force-pushed the CATTY-718-Support-Bricks-in-multiple-categories branch from 4749e10 to 3c769ec Compare September 12, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallisch wallisch Awaiting requested review from wallisch

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lucatp