Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CATTY-717 Allow selection of images from files #1826

Conversation

lucatp
Copy link
Contributor

@lucatp lucatp commented Jul 26, 2023

Implementation of feature CATTY-717 Allow selection of images from files

Implementation of feature CATTY-717.
The Implementation is very similar to the Implementation for selecting sound files from the Finder.

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Verify that the Jira ticket is in the status Ready for Development
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s git workflow (rebase and squash your commits)
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the #catty Slack channel and ask for a code reviewer

@lucatp lucatp requested a review from wallisch July 26, 2023 19:43
@lucatp lucatp self-assigned this Jul 26, 2023
@wallisch
Copy link
Contributor

retest this please

@wallisch wallisch force-pushed the CATTY-717-Allow-selection-of-images-from-files branch from 68d02fb to 38a82a2 Compare October 18, 2024 00:50
Implementation of feature CATTY-717 Allow selection of images from files
@wallisch wallisch force-pushed the CATTY-717-Allow-selection-of-images-from-files branch from 38a82a2 to 6d1ce25 Compare October 18, 2024 00:51
@wallisch wallisch merged commit 44942ca into Catrobat:develop Oct 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants