Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NullPointerException when getting camera preview resolution #563

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chiel99
Copy link

@chiel99 chiel99 commented Aug 28, 2019

Found this crash on v0.13.6.
This PR fixed the exception when the device is trying the perform view onMeasure() but the camera is not opened yet.
So the getCameraPreviewResolution() method will return null (which is fine because the CameraView will adjust later), however, if we also want to invert PreviewSizes, the NullException comes up.

The solution is simply adding the null check.

Logcat:
java.lang.NullPointerException: Attempt to invoke virtual method ‘int com.wonderkiln.camerakit.Size.getHeight()’ on a null object reference
at com.wonderkiln.camerakit.Camera1.getPreviewResolution(Camera1.java:599)
at com.wonderkiln.camerakit.CameraView.getPreviewSize(CameraView.java:518)
at com.wonderkiln.camerakit.CameraView.onMeasure(CameraView.java:197)

Logcat:
java.lang.NullPointerException: Attempt to invoke virtual method ‘int com.wonderkiln.camerakit.Size.getHeight()’ on a null object reference
       at com.wonderkiln.camerakit.Camera1.getPreviewResolution(Camera1.java:599)
       at com.wonderkiln.camerakit.CameraView.getPreviewSize(CameraView.java:518)
       at com.wonderkiln.camerakit.CameraView.onMeasure(CameraView.java:197)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants