Feature/sort talks page #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
July 22, 2024 15:49
hodgestar
reviewed
Aug 19, 2024
Comment on lines
+201
to
+203
| self.assertGreater(pos_talk_a, pos_talk_b) | ||
| self.assertGreater(pos_talk_b, pos_talk_c) | ||
| self.assertGreater(pos_talk_c, pos_talk_d) |
There was a problem hiding this comment.
Is it possible to make this assert closer to self.assertTrue(D < C < B < A)?
There was a problem hiding this comment.
That construction loses information about which specific item was out of order if the test fails.
hodgestar
approved these changes
Aug 19, 2024
Appy feedback from PR Co-authored-by: Stefano Rivera <github@rivera.za.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for sorting the talks list by track, language or title.
We add links to the table headers to switch sorting.
Sorting is currently global, although it can be triggered on any of the tables created by using multiple talk types, but I don't think the complexity of sorting within a type only is worthwhile.
Closes #710