Various model.py language fixes #650
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanor
reviewed
Oct 13, 2022
wafer/schedule/models.py
Outdated
| @@ -79,7 +79,7 @@ class Venue(models.Model): | |||
| " conference attendees")) | |||
|
|
|||
| blocks = models.ManyToManyField(ScheduleBlock, | |||
| help_text=_("Blocks (days) on which this venue will be used.")) | |||
| help_text=_("Blocks (days) this venue will be used.")) | |||
There was a problem hiding this comment.
I disagree with this edit, the string doesn't make any sense any more.
There was a problem hiding this comment.
Blocks this venue will be used on?
comradekingu
commented
Oct 13, 2022
comradekingu
commented
Oct 13, 2022
wafer/schedule/models.py
Outdated
| @@ -79,7 +79,7 @@ class Venue(models.Model): | |||
| " conference attendees")) | |||
|
|
|||
| blocks = models.ManyToManyField(ScheduleBlock, | |||
| help_text=_("Blocks (days) on which this venue will be used.")) | |||
| help_text=_("Blocks (days) this venue will be used.")) | |||
There was a problem hiding this comment.
Suggested change
| help_text=_("Blocks (days) this venue will be used.")) | |
| help_text=_("Occupied blocks (days) for the venue.")) |
I like this a bit better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.