Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the program suspend problems. #62

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

yuhun-Jun
Copy link

Thanks to the author. It is a great SSD simulator.

But in the latest version, the Program Suspend does not work.
It seems that the author blocked it because there were a lot of problems.

I fixed some hidden problems, and it works well again.

There are three major issues.

  1. The suspend-related parameter was not loaded because there is a typo in the XML parsing code
  2. TSU class initialize parameter order is twisted
  3. If the read is performed in the suspended program completion path, try to suspend again with an abnormal internal state.

Correction of problems 1 and 2 was simple.
To solve problem 3, I created a Suspend Lock that prevents retrying the suspend before the previous suspend is complete.

As a result, it was confirmed that Program Suspend was performed well.

@Myles-C
Copy link

Myles-C commented Sep 14, 2023

there is something wrong, code "chip->Resume(dieBKE->ActiveCommand->Address[0].DieID);" line 723 in NVM_PHY_ONFI_NVDDR2.cpp shows dieBKE is nullptr, please help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants