unpin numpy version #345
Open
unpin numpy version #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed the dependencies to not rely on pinned numpy versions which are no longer supported by libraries like zarr
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #345 +/- ##
=======================================
Coverage 79.47% 79.47%
=======================================
Files 16 16
Lines 2076 2076
=======================================
Hits 1650 1650
Misses 426 426 ☔ View full report in Codecov by Sentry. |
|
Thanks for the fix! It would be great if this can get merged and release soon. |
|
Hi guys! Just two questions to this. Could this enable numpy > 2.0 to be installed along with the plugin? If so, have you tested the plugin with it? I am asking because numpy >2.0 brings many changes and some things may not work anymore, and the changes above wouldn't restrain it unless some other dependency does. |
|
fwiw the CI tests for 43f5f82 was done with numpy>2: Edit: I also tested the plotting widget manually with numpy==2.0.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the dependencies to not rely on pinned numpy versions which are no longer supported by libraries like zarr. Thanks to @ziw-liu for bringing it up. Once merged this will close issue #215. I know this will be fixed anyway in v 0.9.0 but it might be good to fix it in this release in case the new version has some backwards compatibility breaking changes.