Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIM: Api / Product / VersionSet / Policy / PolicyFragment #3394

Merged
merged 69 commits into from
Oct 24, 2023

Conversation

ross-p-smith
Copy link
Contributor

@ross-p-smith ross-p-smith commented Oct 9, 2023

Relates to #2747 and builds on #3376

This is the last of my API Management additions and this should now give a bare minimum needed to deploy apis in a cloud native manner.

Special notes for your reviewer:
The Product/Subscription Integration Test is commented out - #3408
Implements #3379

How does this PR make you feel:
gif

If applicable:

  • this PR contains documentation
  • this PR contains tests

@ross-p-smith ross-p-smith changed the title APIM: Api / Product / VersionSet / Policy APIM: Api / Product / VersionSet / Policy / PolicyFragment Oct 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2023

Codecov Report

Merging #3394 (523adae) into main (57a0a4e) will decrease coverage by 0.08%.
Report is 1 commits behind head on main.
The diff coverage is 47.92%.

@@            Coverage Diff             @@
##             main    #3394      +/-   ##
==========================================
- Coverage   54.36%   54.29%   -0.08%     
==========================================
  Files        1545     1566      +21     
  Lines      651527   655434    +3907     
==========================================
+ Hits       354228   355892    +1664     
- Misses     239747   241753    +2006     
- Partials    57552    57789     +237     
Files Coverage Δ
...nagement/customizations/api_extension_types_gen.go 100.00% <100.00%> (ø)
...tomizations/api_version_set_extension_types_gen.go 100.00% <100.00%> (ø)
...ement/customizations/policy_extension_types_gen.go 100.00% <100.00%> (ø)
...tomizations/policy_fragment_extension_types_gen.go 100.00% <100.00%> (ø)
...ment/customizations/product_extension_types_gen.go 100.00% <100.00%> (ø)
...2/api/apimanagement/v1api20220801/api_types_gen.go 48.63% <ø> (ø)
...i/apimanagement/v1api20220801/backend_types_gen.go 41.88% <ø> (ø)
...nagement/v1api20220801storage/backend_types_gen.go 52.72% <ø> (ø)
...ent/v1api20220801storage/subscription_types_gen.go 52.72% <ø> (ø)
...2/internal/controllers/controller_resources_gen.go 84.31% <100.00%> (+0.13%) ⬆️
... and 17 more

... and 48 files with indirect coverage changes

@theunrepentantgeek
Copy link
Member

/ok-to-test sha=349dedc

@theunrepentantgeek
Copy link
Member

/azp run

@theunrepentantgeek
Copy link
Member

I think your CI test failure in test-generator was a flake (I have work underway to improve the reliability of our recorded tests), so I've triggered a re-run of that check.

I've also triggered a full run of integration-tests-fork as well as the Azure.azure-service-operator check.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@theunrepentantgeek
Copy link
Member

/ok-to-test sha=523adae

@theunrepentantgeek
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@theunrepentantgeek theunrepentantgeek added this pull request to the merge queue Oct 24, 2023
@theunrepentantgeek theunrepentantgeek added this to the v2.4.0 milestone Oct 24, 2023
@theunrepentantgeek theunrepentantgeek added the new-resource Requests for new supported resources label Oct 24, 2023
Merged via the queue into Azure:main with commit 993800e Oct 24, 2023
9 checks passed
@ross-p-smith ross-p-smith deleted the ross/Backbaseminimum branch November 21, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-resource Requests for new supported resources
Projects
Development

Successfully merging this pull request may close these issues.

5 participants