Skip to content

Commit

Permalink
cosmetic changes only
Browse files Browse the repository at this point in the history
  • Loading branch information
pohhsu committed Aug 5, 2023
1 parent b4a313f commit 4ea4cf5
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -145,4 +145,4 @@ You can look at the help for analyze command to further customization.

# Deployment
## Running in Azure
The quickest way to run the tool in Azure is use the deployment scripts. See [deployment.md](deployment/deployment.md) for more instruction how to quikcly run it.
The quickest way to run the tool in Azure is use the deployment scripts. See [deployment.md](deployment/deployment.md) for more instructions how to quickly run it.
4 changes: 2 additions & 2 deletions deployment/deployment.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ module mediaRoleAssignment 'roleassignment.bicep' = {

var storageAccountIds = map(mediaAccount.properties.storageAccounts, arg => arg.id)
module storageRoleAssignments 'storageaccounts.bicep' = {
name: 'storageRoleAssignements'
name: 'storageRoleAssignments'
params: {
storageAccounts: storageAccountIds
principalId: managedIdentity.properties.principalId
Expand Down Expand Up @@ -104,7 +104,7 @@ module keyVaultRoleAssignment 'roleassignment.bicep' = if (encrypt) {
}
}

// Default argumetns to the migration tool.
// Default arguments to the migration tool.
var defaultArguments = [
'dotnet'
'AMSMigrate.dll'
Expand Down
6 changes: 3 additions & 3 deletions deployment/deployment.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@ az group create --location location --name migration
```

## Update the parameters.
The parameters for the deplyment are in the file [parameters.bicepparam](parameters.bicepparam).
The parameters for the deployment are in the file [parameters.bicepparam](parameters.bicepparam).
```bicep
// The media account being migrated.
param mediaAccountName = 'accountname'
param mediaAccountRG = 'resourcegroup'
// Thes storage account details where the migrated data is written.
// The storage account details where the migrated data is written.
param storageAccountName = 'storeagaccountname'
param storageAccountRG = 'storageresourcegroup'
```
Expand All @@ -25,7 +25,7 @@ az deployment group create --template-file deployment.bicep --resource-group mig
```

## Monitor progress
While the ACI is running you can mointor the progress of the tool by running.
While the ACI is running you can monitor the progress of the tool by running.
```bash
az container logs --follow -g migration -n azure-media-migration
```
2 changes: 1 addition & 1 deletion deployment/parameters.bicepparam
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
using './deployment.bicep'

// The media serivces account being migrated.
// The media services account being migrated.
param mediaAccountName = 'provenanceuswc'
param mediaAccountRG = 'provenance'

Expand Down
2 changes: 1 addition & 1 deletion deployment/roleassignment.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ param storage bool = false
@description('The role to assign to the resource group of the resource.')
param resourceGroupRoleName string = 'Reader'

@description('Assigna a role to the resoucr group.')
@description('Assign a role to the resource group.')
param assignGroupRole bool = false

var roles = {
Expand Down

0 comments on commit 4ea4cf5

Please sign in to comment.