uplift to stable2407 #1372
uplift to stable2407 #1372
Conversation
vedhavyas
added
astar
pallets/xc-asset-config/src/tests.rs
Outdated
| @@ -16,6 +16,7 @@ | |||
| // You should have received a copy of the GNU General Public License | |||
| // along with Astar. If not, see <http://www.gnu.org/licenses/>. | |||
|
|
|||
| #![allow(deprecated)] | |||
There was a problem hiding this comment.
They have deprecate xcm::v2
i have marked the specific test with deprecated attribute instead of entire file
There was a problem hiding this comment.
Ok, what's the future plan for these tests then?
Will you create an issue to address this later?
Why not address it now?
There was a problem hiding this comment.
The test essentially test failure of the xcm::V2 conversion to xcm::V4. Now that v2 is deprecated I dont think this test is required anymore. I have left it as is for removal in next uplift when v2 is completely removed and we can remove the test all together
vedhavyas
force-pushed
the
uplift-stable2407
branch
from
8ad40ec
to
b9be8d7
Compare
There was a problem hiding this comment.
New treasury changes requires the origin to return the Max amount to spend at a time and I have set the Max to Max Balance.
As for the Payout timeout, I have set 3 days for shibuya and 30 minutes for Local. After this period, the spends are expired
For the treasury changes, we also need to update the docs and inform the Subsquare team to update the UI logic.
@Dinonard How do I start doing that ?
| @@ -620,7 +620,6 @@ fn start_aura_consensus( | |||
| .map(|c| ValidationCode::from(c).hash()) | |||
| } | |||
| }, | |||
| sync_oracle: sync_oracle.clone(), | |||
There was a problem hiding this comment.
Quick question: Why do we have to remove this from the Aura parameters?
There was a problem hiding this comment.
It was never used and was removed in this commit - paritytech/polkadot-sdk@70afa25 (#4097)
yes I'min the process of adding those :) |
Minimum allowed line rate is |
Pull Request Summary
PR uplifts to stable 2407.
Commit one uplifts the project
Commit two bumps the versions
Check list