simplify client

[ermalkaleci]

Pull Request Summary

• Make it possible to choose between libp2p and litep2p. Default to libp2p
• Remove evm-tracing feature to have a single general purpose client. Enabling evm-tracing works the same.
• Remove a lot of unnecessary code related to evm-tracing feature flag and different runtime adaptation
• Update release gha to fit new changes
• Add production profile (optimized)

[github-actions]

Package	Line Rate	Branch Rate	Health
primitives/src	59%	0%	➖
pallets/unified-accounts/src	86%	0%	✔
precompiles/sr25519/src	64%	0%	➖
pallets/collator-selection/src	92%	0%	✔
precompiles/assets-erc20/src	78%	0%	➖
pallets/xc-asset-config/src	50%	0%	➖
pallets/dapp-staking-v3/src	84%	0%	✔
chain-extensions/types/unified-accounts/src	0%	0%	❌
precompiles/unified-accounts/src	100%	0%	✔
pallets/inflation/src	93%	0%	✔
pallets/astar-xcm-benchmarks/src/generic	100%	0%	✔
pallets/static-price-provider/src	85%	0%	✔
precompiles/dapp-staking-v3/src/test	0%	0%	❌
pallets/dapp-staking-v3/rpc/runtime-api/src	0%	0%	❌
precompiles/dispatch-lockdrop/src	86%	0%	✔
pallets/dynamic-evm-base-fee/src	89%	0%	✔
pallets/astar-xcm-benchmarks/src/fungible	100%	0%	✔
pallets/collective-proxy/src	86%	0%	✔
pallets/astar-xcm-benchmarks/src	86%	0%	✔
precompiles/dapp-staking-v3/src	90%	0%	✔
pallets/dapp-staking-v3/src/test	0%	0%	❌
pallets/price-aggregator/src	82%	0%	✔
chain-extensions/types/assets/src	0%	0%	❌
pallets/ethereum-checked/src	74%	0%	➖
pallets/dapp-staking-v3/src/benchmarking	98%	0%	✔
pallets/dapp-staking-migration/src	0%	0%	❌
chain-extensions/pallet-assets/src	56%	0%	➖
precompiles/substrate-ecdsa/src	74%	0%	➖
precompiles/xcm/src	71%	0%	➖
chain-extensions/unified-accounts/src	0%	0%	❌
primitives/src/xcm	65%	0%	➖
Summary	77% (3565 / 4627)	0% (0 / 0)	➖

Minimum allowed line rate is 50%

[ipapandinas]

Great initiative for code maintainability! I'm almost looking forward to the next version uplift 😁

But I have a quick question: Doesn't this design decision to enable EVM tracing for the general client introduce unnecessary overhead for production nodes that don't need it?

[ermalkaleci]

Great initiative for code maintainability! I'm almost looking forward to the next version uplift 😁

But I have a quick question: Doesn't this design decision to enable EVM tracing for the general client introduce unnecessary overhead for production nodes that don't need it?

EVM tracing needs to be enabled by option --ethapi and wasm-runtime-override with custom wasm

[ipapandinas]

LGTM

[Dinonard]

LGTM

Great cleanup!