Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0] Fix issue with last_pending_finalizer_policy_start_timestamp not being set/reflected #551

Merged
merged 6 commits into from
Aug 15, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Aug 15, 2024

Update and FC_REFLECT last_pending_finalizer_policy_start_timestamp.

Add new integration test that stops a producer with a pending finalizer policy. The test fails without the fix in this PR. See https://github.com/AntelopeIO/spring/actions/runs/10404745123/job/28814540344.
Enable a failing unittest that also trips the issue.

Resolves #549

@arhag arhag linked an issue Aug 15, 2024 that may be closed by this pull request
@arhag arhag merged commit bc85111 into release/1.0 Aug 15, 2024
36 checks passed
@arhag arhag deleted the GH-549 branch August 15, 2024 15:34
@heifner heifner added OCI Work exclusive to OCI team consensus-protocol Change to the consensus protocol. Impacts light client validation. labels Aug 15, 2024
@ericpassmore
Copy link
Contributor

Note:start
group: STABILITY
category: INTERNALS
summary: Fix edge case transitioning to finalizer policy on shutdown by setting the correct timestamp for pending finalizer policy change.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus-protocol Change to the consensus protocol. Impacts light client validation. OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add restart production integration test - Fix rc1 issue
6 participants