Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0] Better logging for aggregate_vote failure and add logging for proposer policy becoming active #550

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

linh2931
Copy link
Member

@linh2931 linh2931 commented Aug 15, 2024

  • Log detailed information when verify_sig fails, including block ID, vote strong or weak.
  • Add debug logging when proposer policy becoming active
debug 2024-08-15T12:53:57.365 unit_test block_header_state.cpp:349    finish_next          ] Proposer  policy version change: 0 -> 2
debug 2024-08-15T12:53:57.365 unit_test block_header_state.cpp:351    finish_next          ] New       proposer policy becoming active in block 37:                                                           0000002553a993a7e5895478dd02d8b67716476ca7df7cd78cf221752787f233: {"proposal_time":"2020-  01-01T00:00:11.500","proposer_schedule":{"version":2,"producers":[{"producer_name":"bob",  "authority":[0,         {"threshold":1,"keys":[{"key":                                                                         "EOS5mF6KuJY8NgNqzKS4oUjoq2q6n3txkprAhtjLb1gyi7nJ7QZLD","weight":1}]}]}]}}

libraries/chain/finality/qc.cpp Show resolved Hide resolved
libraries/chain/block_header_state.cpp Show resolved Hide resolved
libraries/chain/block_header_state.cpp Outdated Show resolved Hide resolved
@linh2931 linh2931 merged commit a6327eb into release/1.0 Aug 15, 2024
36 checks passed
@linh2931 linh2931 deleted the better_logging branch August 15, 2024 15:35
@ericpassmore
Copy link
Contributor

Note:start
group: LOGGING
category: INTERNALS
summary: Better logging for aggregate_vote failure, and better logging when proposer policy becomes active.
Note: end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants