Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Wisps to drop with getDrops #1402

Open
wants to merge 2 commits into
base: 1.12-fixes
Choose a base branch
from

Conversation

JoshieGemFinder
Copy link
Collaborator

@JoshieGemFinder JoshieGemFinder commented Mar 6, 2024

Mainly for compatibility with other mods (e.g. an enchantment that automatically captures drops from broken blocks and places them in the user's inventory)

Also, this should properly interact with the doTileDrops gamerule

Mainly for compatibility with other mods (e.g. an automatic breaker that captures the drops of the blocks it breaks)

Also, this should properly interact with the `doTileDrops` gamerule
@JoshieGemFinder
Copy link
Collaborator Author

Where I currently am I cannot properly test how this would interact with pistons et cetera, so I will have to test that when I am able to.

If it has unintended side effects that I cannot fix, I will close the pull request.

Simply adding a check for harvesters to keep the mechanics consistent with explosions and pistons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant