#21 [feat] jwt 토큰 처리 로직 작성 #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KWY0218
reviewed
Jul 9, 2023
Comment on lines
29
to
38
| if (!jwtService.verifyToken(token)) { | ||
| throw new RuntimeException(String.format("USER_ID를 가져오지 못했습니다. (%s - %s)", parameter.getClass(), parameter.getMethod())); | ||
| } | ||
|
|
||
| final String tokenContents = jwtService.getJwtContents(token); | ||
| try { | ||
| return Long.parseLong(tokenContents); | ||
| } catch (NumberFormatException e) { | ||
| throw new RuntimeException(String.format("USER_ID를 가져오지 못했습니다. (%s - %s)", parameter.getClass(), parameter.getMethod())); | ||
| } |
There was a problem hiding this comment.
p2:
해당 에러 메시지는 클라이언트에게 가는 메시지인데, 클라이언트가 parameter의 class 명, parameter의 메서드 명을 알아야 하는지 의문이 드네요..!
또한 RuntimeException으로 던지면 controllerAdivce에서 Exception으로 수집되어 500으로 클라이언트에게 반환이 될 것 같다는 생각이 듭니다..!
따라서 Error 코드를 따로 만들어서 저희가 정의한 NotFoundException 과 같은 에러를 던져주면 좋을 것 같습니다.
KWY0218
approved these changes
Jul 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✒️ 관련 이슈번호
Key Changes 🔑
To Reviewers 📢