Enable targetting v8-A Aarch-32 #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ostannard
reviewed
Sep 4, 2024
cmake/multilib.yaml.in
Outdated
| @@ -148,9 +148,18 @@ Mappings: | |||
| # of each other, in the obvious way, but we don't have any libraries | |||
There was a problem hiding this comment.
Please update this comment to match.
cmake/multilib.yaml.in
Outdated
| @@ -148,9 +148,18 @@ Mappings: | |||
| # of each other, in the obvious way, but we don't have any libraries | |||
| # for those at present, so there's no need to generate all their | |||
| # flags.) | |||
| - Match: --target=armv(8\.[1-9]|9|9\.[1-9])a-unknown-none-eabi | |||
| - Match: --target=armv(8|8\.[1-9]|9|9\.[1-9])a-unknown-none-eabi | |||
There was a problem hiding this comment.
You can use (arm|thumb) in the triple (see armv7ve above for example) to halve the number of Match blocks here, because the ISA doesn't matter for library selection.
dcandler
pushed a commit
to dcandler/LLVM-embedded-toolchain-for-Arm
that referenced
this pull request
Sep 16, 2024
* Enable targetting v8-A Aarch-32 * fixup! Enable targetting v8-A Aarch-32
dcandler
pushed a commit
that referenced
this pull request
Sep 16, 2024
* Enable targetting v8-A Aarch-32 * fixup! Enable targetting v8-A Aarch-32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.