Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statically link libc++abi into libc++ #483

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

ostannard
Copy link
Collaborator

This will prevent C++ links from breaking when
llvm/llvm-project#101259 lands, as that removes -lc++abi and -lunwind from the linker command-line.

This will prevent C++ links from breaking when
llvm/llvm-project#101259 lands, as that removes
-lc++abi and -lunwind from the linker command-line.
Copy link
Contributor

@smithp35 smithp35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for making the change.

@ostannard ostannard merged commit e80e252 into ARM-software:main Sep 3, 2024
1 check passed
dcandler added a commit to dcandler/LLVM-embedded-toolchain-for-Arm that referenced this pull request Sep 10, 2024
The following changes to LLVM ET were made in response to changes in LLVM
which happened after the LLVM 19 branch, and therefore do not need to be on
our branch either:

Statically link libc++abi into libc++ (ARM-software#483)
e80e252

Update a downstream patch for altered context (NFC)
d95a4fa

Fix a patch conflict in libc++ tests.
7616f8c

Do not default to linking crt0 when using crt0-semihosting (ARM-software#460)
39523a0

Remove patch since llvm sort.pass.cpp is already marked as a long test (ARM-software#458)
3b32a82
dcandler added a commit to dcandler/LLVM-embedded-toolchain-for-Arm that referenced this pull request Sep 10, 2024
The following changes to LLVM ET were made in response to changes in LLVM
which happened after the LLVM 19 branch, and therefore do not need to be on
our branch either:

Statically link libc++abi into libc++ (ARM-software#483)
e80e252

Update a downstream patch for altered context (NFC)
d95a4fa

Fix a patch conflict in libc++ tests.
7616f8c

Do not default to linking crt0 when using crt0-semihosting (ARM-software#460)
39523a0

Remove patch since llvm sort.pass.cpp is already marked as a long test (ARM-software#458)
3b32a82

Update patch file for libc++ tests with picolibc, to mark sort test as long one (ARM-software#457)
9a53fc9
dcandler added a commit to dcandler/LLVM-embedded-toolchain-for-Arm that referenced this pull request Sep 12, 2024
The following changes to LLVM ET were made in response to changes in LLVM
which happened after the LLVM 19 branch, and therefore do not need to be on
our branch either:

Statically link libc++abi into libc++ (ARM-software#483)
e80e252

Update a downstream patch for altered context (NFC)
d95a4fa

Fix a patch conflict in libc++ tests.
7616f8c

Do not default to linking crt0 when using crt0-semihosting (ARM-software#460)
39523a0

Remove patch since llvm sort.pass.cpp is already marked as a long test (ARM-software#458)
3b32a82

Update patch file for libc++ tests with picolibc, to mark sort test as long one (ARM-software#457)
9a53fc9
dcandler added a commit that referenced this pull request Sep 16, 2024
The following changes to LLVM ET were made in response to changes in LLVM
which happened after the LLVM 19 branch, and therefore do not need to be on
our branch either:

Statically link libc++abi into libc++ (#483)
e80e252

Update a downstream patch for altered context (NFC)
d95a4fa

Fix a patch conflict in libc++ tests.
7616f8c

Do not default to linking crt0 when using crt0-semihosting (#460)
39523a0

Remove patch since llvm sort.pass.cpp is already marked as a long test (#458)
3b32a82

Update patch file for libc++ tests with picolibc, to mark sort test as long one (#457)
9a53fc9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants