Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add WP and PHP minimum badges #150

Merged
merged 1 commit into from
Sep 26, 2024
Merged

add WP and PHP minimum badges #150

merged 1 commit into from
Sep 26, 2024

Conversation

jeffpaul
Copy link
Member

Description of the Change

This PR adds badges to note the WordPress and PHP minimums for this plugin. I did NOT remove the "Requirements" section of the README.md file, but I wonder if that might be worthwhile so that we don't need to worry about remembering to update those references in the future (as the badges auto-update based on what's shown on the WP.org repo)?

How to test the Change

Use GitHub markdown previewer to see updated badges.

Changelog Entry

n/a

Credits

Props @jeffpaul.

Checklist:

@jeffpaul jeffpaul added this to the 1.4.0 milestone Sep 26, 2024
@jeffpaul jeffpaul self-assigned this Sep 26, 2024
@dkotter
Copy link
Collaborator

dkotter commented Sep 26, 2024

I did NOT remove the "Requirements" section of the README.md file, but I wonder if that might be worthwhile so that we don't need to worry about remembering to update those references in the future

I'm not strongly opinionated either way on this one. I personally feel the "Requirements" section is easier to see and parse as opposed to this long list of badges, so I like having both but it does duplicate that information so does also make sense to just remove it.

@dkotter dkotter merged commit 965049b into develop Sep 26, 2024
10 checks passed
@dkotter dkotter deleted the add/wp-php-badges branch September 26, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants