Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency conflicts #134

Merged
merged 7 commits into from
Jul 8, 2024
Merged

Fix dependency conflicts #134

merged 7 commits into from
Jul 8, 2024

Conversation

peterwilsoncc
Copy link
Contributor

Description of the Change

Makes the following changes to dependencies:

  • updates wp-scripts and wp-env
  • removes @wordpress/* and lodash production dependencies as they are supplied by wp-scripts
  • Runs npm audit fix

This resolves most of the errors I am seeing in the post editor but I am still seeing Uncaught (in promise) TypeError: ReadableStream.cancel: Cannot cancel a stream locked by a reader. but I think it's pretty safe to ignore.

The main issues I am seeing with the blocks are resolved.

Closes #

How to test the Change

The following will need to be tested:

  • wp-env (start, stop, destroy)
  • wp-scripts (start, build)
  • E2E tests

Changelog Entry

Fixed - JavaScript errors in block editor.
Security - NPM packages updated.

Credits

Props @username, @username2, ...

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@jeffpaul jeffpaul added this to the 1.4.0 milestone May 15, 2024
@jeffpaul jeffpaul requested a review from Sidsector9 June 25, 2024 21:20
@jeffpaul jeffpaul modified the milestones: 1.3.2, 1.4.0 Jun 26, 2024
@jeffpaul jeffpaul marked this pull request as ready for review July 8, 2024 17:23
@jeffpaul jeffpaul merged commit 968c407 into develop Jul 8, 2024
10 checks passed
@jeffpaul jeffpaul deleted the fix/dependency-conflicts branch July 8, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants