Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only validate a locale based on the configuration #845

Merged
merged 3 commits into from
Aug 9, 2024

Conversation

sambrodie
Copy link
Contributor

Description of the Change

Closes #844

How to test the Change

  • Install Polylang
  • And English and at least 1 other language, and set English to the default language
  • Create an English page
  • View the English page

Changelog Entry

Fixed - Fixed isValidLocale function to validate against the configuration
Added - New test condition for technically valid, but unsupported locale

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@sambrodie sambrodie self-assigned this Aug 9, 2024
Copy link

changeset-bot bot commented Aug 9, 2024

🦋 Changeset detected

Latest commit: 9962db0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@headstartwp/next Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Aug 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
headstarwp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2024 2:50pm

Copy link
Contributor

github-actions bot commented Aug 9, 2024

📦 Next.js Bundle Analysis for @10up/headstartwp

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Contributor

github-actions bot commented Aug 9, 2024

📦 Next.js Bundle Analysis for @10up/headstartwp

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@nicholasio nicholasio merged commit 0c735b7 into develop Aug 9, 2024
13 checks passed
@nicholasio nicholasio deleted the fix/polylang-app-router-locale branch August 9, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

With Polylang, error rendering pages in default language
2 participants