Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Category Path Matching #639

Merged
merged 21 commits into from
Nov 20, 2023
Merged

Category Path Matching #639

merged 21 commits into from
Nov 20, 2023

Conversation

nicholasio
Copy link
Member

@nicholasio nicholasio commented Nov 14, 2023

Description of the Change

Closes #369

How to test the Change

  1. npm run dev
  2. Open an category (or tag) archive
  3. Make sure it loads archive pages correctly.
  4. Then add a fake parent term e.g: /category/fake-parent/real-term-name and make sure it 404.
  5. Do the same for tags archive
  6. In headstartwp.config.js, change matchArchivePath to false, now confirm step 4 does not issue a 404!

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

Copy link

changeset-bot bot commented Nov 14, 2023

🦋 Changeset detected

Latest commit: 0b12f64

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@headstartwp/core Minor
@headstartwp/next Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
headstarwp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2023 1:36pm

This comment was marked as outdated.

@nicholasio nicholasio changed the title feat: first pass at matching category path Category Path Matching Nov 15, 2023

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Copy link
Contributor

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 118.41 KB (-2 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Seven Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (145 KB)
/ 9.33 KB 127.73 KB 88.09% (🟡 +0.20%)
/[...path] 6.41 KB 124.81 KB 86.08% (+/- <0.01%)
/author/[...path] 5.98 KB 124.38 KB 85.78% (🟡 +0.43%)
/blog/[[...path]] 9.69 KB 128.09 KB 88.34% (🟡 +0.20%)
/category/[...path] 5.72 KB 124.13 KB 85.61% (🟡 +0.41%)
/search/[[...path]] 5.31 KB 123.71 KB 85.32% (🟡 +0.52%)
/tag/[...path] 5.76 KB 124.16 KB 85.63% (🟡 +0.42%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link
Member

@tobeycodes tobeycodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally works well.

@nicholasio nicholasio mentioned this pull request Nov 20, 2023
1 task
@nicholasio nicholasio merged commit 6dc435f into develop Nov 20, 2023
11 checks passed
@nicholasio nicholasio deleted the feat/match-category-pages branch November 20, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Match category path
2 participants