From ad5953e9303bb870c9de95a71a403beab0f3f943 Mon Sep 17 00:00:00 2001 From: LEE SO JUNG <90453158+xxoznge@users.noreply.github.com> Date: Fri, 5 Jul 2024 04:08:10 +0900 Subject: [PATCH] =?UTF-8?q?refactor:=20commentController=20=EB=B3=80?= =?UTF-8?q?=EA=B2=BD=20(#71)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../domain/comment/controller/CommentController.java | 7 +------ .../domain/comment/service/CommentQueryService.java | 2 +- .../domain/comment/service/CommentService.java | 1 - 3 files changed, 2 insertions(+), 8 deletions(-) diff --git a/src/main/java/com/ddabong/ddabongdotchiBE/domain/comment/controller/CommentController.java b/src/main/java/com/ddabong/ddabongdotchiBE/domain/comment/controller/CommentController.java index 144d3b4..592ced6 100644 --- a/src/main/java/com/ddabong/ddabongdotchiBE/domain/comment/controller/CommentController.java +++ b/src/main/java/com/ddabong/ddabongdotchiBE/domain/comment/controller/CommentController.java @@ -1,6 +1,5 @@ package com.ddabong.ddabongdotchiBE.domain.comment.controller; -import java.util.Collections; import java.util.List; import org.springframework.web.bind.annotation.GetMapping; @@ -42,10 +41,6 @@ public ApiResponse createComment( @GetMapping("/{cardId}") public ApiResponse> getComment(@PathVariable Long cardId) { - List commentResponses = commentQueryService.getComment(cardId); - if (!commentResponses.isEmpty()) { - return ApiResponse.onSuccess(commentResponses); - } - return ApiResponse.onSuccess(Collections.emptyList()); + return ApiResponse.onSuccess(commentQueryService.getComment(cardId)); } } diff --git a/src/main/java/com/ddabong/ddabongdotchiBE/domain/comment/service/CommentQueryService.java b/src/main/java/com/ddabong/ddabongdotchiBE/domain/comment/service/CommentQueryService.java index bae8f8e..63fd96d 100644 --- a/src/main/java/com/ddabong/ddabongdotchiBE/domain/comment/service/CommentQueryService.java +++ b/src/main/java/com/ddabong/ddabongdotchiBE/domain/comment/service/CommentQueryService.java @@ -20,7 +20,7 @@ public class CommentQueryService { public List getComment(Long cardId) { return commentRepository.findByCardIdOrderByCreatedAtDesc(cardId) .stream() - .map(comment -> CommentGetResponse.from(comment)) + .map(CommentGetResponse::from) .toList(); } } diff --git a/src/main/java/com/ddabong/ddabongdotchiBE/domain/comment/service/CommentService.java b/src/main/java/com/ddabong/ddabongdotchiBE/domain/comment/service/CommentService.java index 8cf2297..b58ea67 100644 --- a/src/main/java/com/ddabong/ddabongdotchiBE/domain/comment/service/CommentService.java +++ b/src/main/java/com/ddabong/ddabongdotchiBE/domain/comment/service/CommentService.java @@ -29,7 +29,6 @@ public CommentCreateResponse createComment( User authUser, CommentCreateRequest request ) { - Card card = cardRepository.findById(request.cardId()) .orElseThrow(() -> new CardExceptionHandler(CardErrorCode.CARD_NOT_FOUND));