From 9da27b0dee68f2392914864ea0a583e192c946d7 Mon Sep 17 00:00:00 2001 From: Sereza7 Date: Wed, 17 Jan 2024 14:00:39 +0100 Subject: [PATCH] XWIKI-21777: Admin section: make the PDF export section pass webstandard tests * Added a missing space between attributes in the pdf generator select * Replaced the comment with an actual test for the export PDF section --- .../src/main/resources/XWiki/PDFExport/ConfigurationSheet.xml | 2 +- .../xwiki-platform-distribution-flavor-test/pom.xml | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/xwiki-platform-core/xwiki-platform-export/xwiki-platform-export-pdf/xwiki-platform-export-pdf-ui/src/main/resources/XWiki/PDFExport/ConfigurationSheet.xml b/xwiki-platform-core/xwiki-platform-export/xwiki-platform-export-pdf/xwiki-platform-export-pdf-ui/src/main/resources/XWiki/PDFExport/ConfigurationSheet.xml index 3c427efdd195..188c00bae480 100644 --- a/xwiki-platform-core/xwiki-platform-export/xwiki-platform-export-pdf/xwiki-platform-export-pdf-ui/src/main/resources/XWiki/PDFExport/ConfigurationSheet.xml +++ b/xwiki-platform-core/xwiki-platform-export/xwiki-platform-export-pdf/xwiki-platform-export-pdf-ui/src/main/resources/XWiki/PDFExport/ConfigurationSheet.xml @@ -106,7 +106,7 @@ <select id="pdfGenerator"> #foreach ($pdfGenerator in ['userBrowser', 'chromeDockerContainer', 'remoteChrome']) <option value="$escapetool.xml($pdfGenerator)" - #if ($pdfGenerator == $selectedPDFGenerator)selected="selected"#end + #if ($pdfGenerator == $selectedPDFGenerator)selected="selected" #end title="$escapetool.xml($services.localization.render("export.pdf.generator.${pdfGenerator}.hint"))"> $escapetool.xml($services.localization.render("export.pdf.generator.${pdfGenerator}.label")) </option> diff --git a/xwiki-platform-distribution/xwiki-platform-distribution-flavor/xwiki-platform-distribution-flavor-test/pom.xml b/xwiki-platform-distribution/xwiki-platform-distribution-flavor/xwiki-platform-distribution-flavor-test/pom.xml index f5a55a5f66c5..cd1c915fb49e 100644 --- a/xwiki-platform-distribution/xwiki-platform-distribution-flavor/xwiki-platform-distribution-flavor-test/pom.xml +++ b/xwiki-platform-distribution/xwiki-platform-distribution-flavor/xwiki-platform-distribution-flavor-test/pom.xml @@ -274,8 +274,7 @@ /xwiki/bin/admin/XWiki/XWikiPreferences?editor=globaladmin&section=Localization /xwiki/bin/import/XWiki/XWikiPreferences?editor=globaladmin&section=Import /xwiki/bin/admin/XWiki/XWikiPreferences?editor=globaladmin&section=Export - + /xwiki/bin/admin/XWiki/XWikiPreferences?editor=globaladmin&section=export.pdf /xwiki/bin/admin/XWiki/XWikiPreferences?editor=globaladmin&section=Programming /xwiki/bin/admin/XWiki/XWikiPreferences?editor=globaladmin&section=Annotations /xwiki/bin/admin/XWiki/XWikiPreferences?editor=globaladmin&section=XWiki.OfficeImporterAdmin