Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing headers for compiling xtensor-zarr #67

Open
hankliu5 opened this issue Jul 20, 2021 · 1 comment
Open

Missing headers for compiling xtensor-zarr #67

hankliu5 opened this issue Jul 20, 2021 · 1 comment

Comments

@hankliu5
Copy link
Contributor

Hello all,

I was trying to compile xtensor-zarr but found out that some zarray headers were not installed through make install.
Those headers are:

${ZARRAY_INCLUDE_DIR}/zarray/zfunctors.hpp
${ZARRAY_INCLUDE_DIR}/zarray/zarray_impl_register.hpp
${ZARRAY_INCLUDE_DIR}/zarray/zmpl.hpp
${ZARRAY_INCLUDE_DIR}/zarray/zarray_temporary_pool.hpp
${ZARRAY_INCLUDE_DIR}/zarray/zinit.hpp
${ZARRAY_INCLUDE_DIR}/zarray/zreducers.hpp
${ZARRAY_INCLUDE_DIR}/zarray/zreducer.hpp
${ZARRAY_INCLUDE_DIR}/zarray/zreducer_options.hpp
${ZARRAY_INCLUDE_DIR}/zarray/zarray_zarray.hpp

It seems that those missing headers are not used directly in xtensor-zarr, but they are included for internal usages of other zarray headers.

I'm not sure whether it is the intention or not, but installing missing headers like #66 allows me to compile xtensor-zarr successfully.

Also, zarray depends on nlohmann_json, but this library is not mentioned in README/Dependencies.

-Hank

@JohanMabille
Copy link
Member

I'm not sure whether it is the intention or not

This is definitely a bug. We reorganized the code a lot recently and missed that, thanks for finding it (and fixing it)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants