Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this file fixx11h.h still useful nowdays? #888

Closed
xiaoyifang opened this issue Jun 21, 2023 · 3 comments
Closed

Is this file fixx11h.h still useful nowdays? #888

xiaoyifang opened this issue Jun 21, 2023 · 3 comments

Comments

@xiaoyifang
Copy link
Owner

#ifdef Unsorted
#undef Unsorted
#endif
#ifdef None
#undef None
#endif
#ifdef Bool
#undef Bool
#endif
#ifdef FontChange
#undef FontChange
#endif
#ifdef KeyPress
#undef KeyPress
#endif
#ifdef KeyRelease
#undef KeyRelease
#endif
#ifdef Above
#undef Above
#endif
#ifdef Below
#undef Below
#endif
#ifdef FocusIn
#undef FocusIn
#endif
#ifdef FocusOut
#undef FocusOut
#endif
#ifdef Always
#undef Always
#endif
#ifdef Success
#undef Success
#endif
#ifdef GrayScale
#undef GrayScale

@xiaoyifang xiaoyifang changed the title Is this file still useful nowdays? Is this file fixx11.h still useful nowdays? Jun 21, 2023
@xiaoyifang xiaoyifang changed the title Is this file fixx11.h still useful nowdays? Is this file fixx11h.h still useful nowdays? Jun 21, 2023
@shenlebantongying
Copy link
Collaborator

shenlebantongying commented Jun 21, 2023

I tried to remove it before but failed.

The KDE's codebase still have this and the problematic part of x11 headers is unchanged.

We cannot avoid direct x11 usages yet.

@xiaoyifang
Copy link
Owner Author

Ok, this can be marked as in the future.

@shenlebantongying
Copy link
Collaborator

shenlebantongying commented Oct 19, 2024

I think we need it forever. Because the insanity of X11 redefining common names to macros is not going to be fixed and the part in GD that require X11 cannot be removed (in foreseeable future).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants