From a11c9e3aeca4329e1982d8fe26bacbb21ab50ddf Mon Sep 17 00:00:00 2001 From: shenleban tongying Date: Thu, 10 Oct 2024 03:13:23 -0400 Subject: [PATCH 1/2] clean: mass apply clang-tidy's `readability-braces-around-statements` --- .clang-tidy | 1 - src/article_maker.cc | 93 ++-- src/article_netmgr.cc | 35 +- src/audiolink.cc | 6 +- src/audiooutput.cc | 23 +- src/audioplayerfactory.cc | 12 +- src/common/filetype.cc | 12 +- src/common/folding.cc | 39 +- src/common/htmlescape.cc | 12 +- src/common/iconv.cc | 3 +- src/common/utf8.cc | 72 ++- src/common/utils.cc | 3 +- src/common/wstring_qt.cc | 9 +- src/config.cc | 302 ++++++++---- src/dict/aard.cc | 162 ++++--- src/dict/bgl.cc | 137 ++++-- src/dict/bgl_babylon.cc | 183 +++++--- src/dict/btreeidx.cc | 213 ++++++--- src/dict/chinese.cc | 12 +- src/dict/chunkedstorage.cc | 36 +- src/dict/dictdfiles.cc | 97 ++-- src/dict/dictionary.cc | 94 ++-- src/dict/dictionary.hh | 4 +- src/dict/dictserver.cc | 102 ++-- src/dict/dsl.cc | 331 ++++++++----- src/dict/dsl_details.cc | 230 ++++++--- src/dict/epwing.cc | 3 +- src/dict/epwing_book.cc | 13 +- src/dict/forvo.cc | 26 +- src/dict/gls.cc | 139 ++++-- src/dict/hunspell.cc | 67 ++- src/dict/lingualibre.cc | 3 +- src/dict/loaddictionaries.cc | 24 +- src/dict/lsa.cc | 74 +-- src/dict/mdictparser.cc | 105 +++-- src/dict/mdx.cc | 98 ++-- src/dict/mediawiki.cc | 79 ++-- src/dict/programs.cc | 48 +- src/dict/sdict.cc | 97 ++-- src/dict/slob.cc | 180 ++++--- src/dict/sounddir.cc | 39 +- src/dict/sources.cc | 270 +++++++---- src/dict/stardict.cc | 288 ++++++++---- src/dict/transliteration.cc | 9 +- src/dict/utils/decompress.cc | 24 +- src/dict/utils/dictfile.cc | 24 +- src/dict/utils/dictzip.c | 55 ++- src/dict/utils/indexedzip.cc | 33 +- src/dict/utils/ripemd.cc | 12 +- src/dict/utils/splitfile.cc | 36 +- src/dict/utils/zipfile.cc | 69 ++- src/dict/website.cc | 66 ++- src/dict/xdxf.cc | 144 ++++-- src/dict/xdxf2html.cc | 165 ++++--- src/dict/zim.cc | 51 +- src/dict/zipsounds.cc | 42 +- src/dictionary_group.cc | 6 +- src/externalaudioplayer.cc | 12 +- src/externalviewer.cc | 12 +- src/ffmpegaudio.cc | 43 +- src/ftshelpers.cc | 17 +- src/fulltextsearch.cc | 106 +++-- src/headwordsmodel.cc | 21 +- src/history.cc | 12 +- src/hotkeywrapper.cc | 21 +- src/hotkeywrapper.hh | 18 +- src/iframeschemehandler.cc | 6 +- src/instances.cc | 36 +- src/keyboardstate.hh | 8 +- src/langcoder.cc | 9 +- src/language.cc | 18 +- src/macos/machotkeywrapper.mm | 45 +- src/macos/macmouseover.mm | 109 +++-- src/main.cc | 18 +- src/multimediaaudioplayer.cc | 3 +- src/pronounceengine.cc | 12 +- src/resourceschemehandler.cc | 3 +- src/speechclient.cc | 6 +- src/speechclient.hh | 6 +- src/termination.cc | 3 +- src/ui/articleview.cc | 292 ++++++++---- src/ui/articlewebview.cc | 3 +- src/ui/dictheadwords.cc | 74 +-- src/ui/dictinfo.cc | 12 +- src/ui/dictionarybar.cc | 39 +- src/ui/editdictionaries.cc | 26 +- src/ui/favoritespanewidget.cc | 168 ++++--- src/ui/groupcombobox.cc | 24 +- src/ui/groups.cc | 24 +- src/ui/groups_widgets.cc | 165 ++++--- src/ui/historypanewidget.cc | 12 +- src/ui/mainwindow.cc | 439 ++++++++++++------ src/ui/orderandprops.cc | 56 ++- src/ui/preferences.cc | 27 +- src/ui/scanflag.cc | 9 +- src/ui/scanpopup.cc | 147 ++++-- src/ui/stylescombobox.cc | 3 +- src/ui/translatebox.cc | 3 +- src/webmultimediadownload.cc | 6 +- src/wordfinder.cc | 106 +++-- .../qtsingleapplication/src/qtlocalpeer.cpp | 21 +- .../src/qtsingleapplication.cpp | 5 +- 102 files changed, 4444 insertions(+), 2273 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index 6b2fd3721..420755031 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -33,7 +33,6 @@ Checks: > -modernize-deprecated-headers, -modernize-use-nodiscard, -modernize-use-trailing-return-type, - -readability-braces-around-statements, -readability-function-cognitive-complexity, -readability-identifier-length, -readability-magic-numbers, diff --git a/src/article_maker.cc b/src/article_maker.cc index eac360474..d0b10279a 100644 --- a/src/article_maker.cc +++ b/src/article_maker.cc @@ -123,9 +123,10 @@ std::string ArticleMaker::makeHtmlHeader( QString const & word, QString const & // This doesn't seem to be much of influence right now, but we'll keep // it anyway. - if ( icon.size() ) + if ( icon.size() ) { result += R"(\n"; + } result += QString::fromUtf8( R"(