Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Script Fails When dde Network is Missing #70

Open
sbaerlocher opened this issue Feb 27, 2024 · 2 comments
Open

Bug: Script Fails When dde Network is Missing #70

sbaerlocher opened this issue Feb 27, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@sbaerlocher
Copy link
Contributor

Description
When executing the dde system:update command, an error occurs if the dde network is not present. This results in an error message and the termination of the script. The exact error is: Error response from daemon: network dde not found.

Steps to Reproduce

  1. Run the dde system:update command without the dde network being present.
  2. Observe the error.

Expected Behavior
The script should handle the absence of the dde network gracefully and display an appropriate message instead of failing with an error.

Actual Behavior
The script crashes with the error message Error response from daemon: network dde not found.

Possible Solution
Add a check in line 11 of the destroy.sh script to verify if the dde network exists before attempting to remove it. This could be achieved with the following bash code:

if docker network ls | grep -q dde; then
  docker network rm dde
else
  echo "Network 'dde' not found, no removal necessary."
fi
@sbaerlocher sbaerlocher added the bug Something isn't working label Feb 27, 2024
@sbaerlocher sbaerlocher self-assigned this Feb 27, 2024
@rugbymauri
Copy link
Contributor

not sure, but the problem is caused by the " in the docker-compose.yaml

this should work

networks:
    default:
        name: dde
        external: true

@sbaerlocher
Copy link
Contributor Author

No, I do not suspect that this is the problem, as executing dde system:destroy directly works without any issues. However, when combined – first executing dde system:destroy and then dde system:update – it leads to network problems between lines 10-12 in the destroy.sh, during the execution of the command from dde system:update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants