Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Production build doesn't deal with default exports of react-sparkle #2653

Closed
eliseumds opened this issue Mar 23, 2021 · 1 comment
Closed

Production build doesn't deal with default exports of react-sparkle #2653

eliseumds opened this issue Mar 23, 2021 · 1 comment
Labels
duplicate This issue or pull request already exists pending triage

Comments

@eliseumds
Copy link

eliseumds commented Mar 23, 2021 •
edited
Loading

Describe the bug

I was playing around with vite and realised that importing react-sparkle (v1.0.8) in development works as expected, but not in production.

I get this in development:

Screen Shot 2021-03-23 at 9 06 56 am

And this in production:

Screen Shot 2021-03-23 at 9 07 14 am

Reproduction

https://github.com/eliseumds/vite_default_import_bug

System Info

  • vite version: vite/2.1.2 darwin-x64 node-v15.5.0
  • Operating System: macOS 10.15.7
  • Package manager: tried with both Yarn and NPM
@patak-dev
Copy link
Member

Closing as duplicate of #2139, looks like this is an upstream issue with rollup.

@Shinigami92 Shinigami92 added the duplicate This issue or pull request already exists label Mar 29, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists pending triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@patak-dev @eliseumds @Shinigami92