Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to update ctxRenderer for custom shapes #2171

Open
dmarov opened this issue Jul 10, 2024 · 1 comment · May be fixed by #2172
Open

Unable to update ctxRenderer for custom shapes #2171

dmarov opened this issue Jul 10, 2024 · 1 comment · May be fixed by #2172

Comments

@dmarov
Copy link

dmarov commented Jul 10, 2024

  • browser: latest firefox
  • OS: Windows 10

I was unable to update ctxRenderer for custom shape in vis-network using function updateOnly

Code example: https://codepen.io/Dmitry-Marov/pen/WNqbEXN

Expected result: red square changes to green circle and back every second.
Actual result: red square does not change to green circle, even though ctxRenderer function gets updated.
dmarov pushed a commit to dmarov/vis-network that referenced this issue Jul 10, 2024
bugfix(lib): fix visjs#2171 ctxRenderer update for custom shapes
197f26c
dmarov pushed a commit to dmarov/vis-network that referenced this issue Jul 10, 2024
bugfix(lib): fix visjs#2171 ctxRenderer update for custom shapes
462b555
dmarov pushed a commit to dmarov/vis-network that referenced this issue Jul 10, 2024
bugfix(lib): fix visjs#2171 ctxRenderer update for custom shapes
3b7acee
dmarov pushed a commit to dmarov/vis-network that referenced this issue Jul 10, 2024
bugfix(lib): fix visjs#2171 ctxRenderer update for custom shapes
df3881d
@dmarov dmarov linked a pull request Jul 10, 2024 that will close this issue
Open
dmarov pushed a commit to dmarov/vis-network that referenced this issue Jul 10, 2024
bugfix(lib): fix visjs#2171 ctxRenderer update for custom shapes
de326af
@dmarov
Copy link
Author

dmarov commented Jul 20, 2024

I've fixed this issue in https://www.npmjs.com/package/@diyguy/vis-network since MR got stuck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes #2171 Unable to update ctxRenderer for custom shapes dmarov/vis-network
1 participant
@dmarov