From 35a79d6d308d6c4eaca85c4ed92fee2ac2b3f9b9 Mon Sep 17 00:00:00 2001 From: Alexis Boissiere Date: Tue, 27 Feb 2024 13:42:48 +0100 Subject: [PATCH 1/3] fix(deployment): conflict between ArgoCD and Keda --- charts/verdaccio/templates/deployment.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/charts/verdaccio/templates/deployment.yaml b/charts/verdaccio/templates/deployment.yaml index 52a0e0e..72e6953 100644 --- a/charts/verdaccio/templates/deployment.yaml +++ b/charts/verdaccio/templates/deployment.yaml @@ -9,7 +9,9 @@ metadata: {{- toYaml . | nindent 4 }} {{- end }} spec: - replicas: {{ default 1 .Values.replicaCount }} + {{- if not (eq nil .Values.replicaCount) }} + replicas: {{ .Values.replicaCount }} + {{- end}} revisionHistoryLimit: {{ .Values.revisionHistoryLimit }} selector: matchLabels: From 5550fdb5d5ae6af2c5b2b184d27106e352f2afd4 Mon Sep 17 00:00:00 2001 From: Alexis Boissiere Date: Tue, 5 Mar 2024 12:06:49 +0100 Subject: [PATCH 2/3] bump(chart): version --- charts/verdaccio/Chart.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/charts/verdaccio/Chart.yaml b/charts/verdaccio/Chart.yaml index 3e71678..fac3b45 100644 --- a/charts/verdaccio/Chart.yaml +++ b/charts/verdaccio/Chart.yaml @@ -1,7 +1,7 @@ apiVersion: v2 description: A lightweight private node.js proxy registry name: verdaccio -version: 4.16.0 +version: 4.16.1 appVersion: 5.29.0 home: https://verdaccio.org icon: https://cdn.verdaccio.dev/logos/default.png From e87f33da05667181f0afe02f76a417a372b4e8d7 Mon Sep 17 00:00:00 2001 From: Alexis Boissiere Date: Tue, 19 Mar 2024 11:30:25 +0100 Subject: [PATCH 3/3] fix(deployment): type comparaison --- README.md | 1 + charts/verdaccio/templates/deployment.yaml | 4 ++-- charts/verdaccio/values.yaml | 1 + 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 9175ca9..ef2a483 100644 --- a/README.md +++ b/README.md @@ -106,6 +106,7 @@ and their default values. | `priorityClass.enabled` | Enable specifying pod priorityClassName | `false` | | `priorityClass.name` | PriorityClassName to be specified in pod spec | `""` | | `replicaCount` | Desired number of pods | `1` | +| `replicaCountEnabled` | Enable the replicaCount field | `true` | | `livenessProbe` | Configuration of liveness probe | `{}` | | `readinessProbe` | Configuration of readiness probe | `{}` | | `resources` | CPU/Memory resource requests/limits | `{}` | diff --git a/charts/verdaccio/templates/deployment.yaml b/charts/verdaccio/templates/deployment.yaml index 72e6953..6c0b087 100644 --- a/charts/verdaccio/templates/deployment.yaml +++ b/charts/verdaccio/templates/deployment.yaml @@ -9,8 +9,8 @@ metadata: {{- toYaml . | nindent 4 }} {{- end }} spec: - {{- if not (eq nil .Values.replicaCount) }} - replicas: {{ .Values.replicaCount }} + {{- if .Values.replicaCountEnabled }} + replicas: {{ default 1 .Values.replicaCount }} {{- end}} revisionHistoryLimit: {{ .Values.revisionHistoryLimit }} selector: diff --git a/charts/verdaccio/values.yaml b/charts/verdaccio/values.yaml index dc4448a..7e832fd 100644 --- a/charts/verdaccio/values.yaml +++ b/charts/verdaccio/values.yaml @@ -46,6 +46,7 @@ podLabels: {} ## podAnnotations: {} +replicaCountEnabled: true replicaCount: 1 revisionHistoryLimit: 10