Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In v00.12.00 LatestArticleOptions.ascx still has maxlength="50" attributes #72

Open
RichardHowells opened this issue Oct 29, 2021 · 3 comments
Assignees
Labels

Comments

@RichardHowells
Copy link

I'm puzzled. AFAICT Timo's pull request #53 (removing maxlength="50") is included in the release v00.12.00

I downloaded the install zip file and installed it on my site. I find there is still a 50 char limit (on the template body et al) and the attribute maxlength="50" is still there.

I opened the install zip file (NewsArticles.00.12.00.zip) and looked in LatestArticleOptions.ascx. The maxlength="50" attributes also appear in there.

Has there been some kind of error in preparing the release?

Am I missing something?

@Timo-Breumelhof
Copy link
Collaborator

I think that the fix is in the code base but not in the "latest release", as that's from a year ago.

@Timo-Breumelhof
Copy link
Collaborator

Hmm, no #51 is integrated before the release date. @skamphuis any idea what could be the reason for this?

@RichardHowells
Copy link
Author

AIUI this is the list of commits included in the tag v00.12.00. That's what led me to expect @Timo-Breumelhof's change to be included.

https://github.com/ventrian/News-Articles/commits/v00.12.00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants