From 291e5e4b8af09ebfd3363289dffc386ef8d0605e Mon Sep 17 00:00:00 2001 From: Dane Miluski Date: Mon, 4 Nov 2019 23:06:00 -0800 Subject: [PATCH] Based on prior PR which went stale: https://github.com/venmo/DVR/pull/70 by https://github.com/ocurr Goal: Expose currentRequest which should be expected given URLSessionDataTask subclass Reasoning: By exposing currentTask, SessionDataTask can provide request for easy logging support Changes: - Provide currentRequest override + test --- Sources/DVR/SessionDataTask.swift | 4 ++++ Tests/DVRTests/SessionTests.swift | 2 ++ 2 files changed, 6 insertions(+) diff --git a/Sources/DVR/SessionDataTask.swift b/Sources/DVR/SessionDataTask.swift index 8ac1a3a..532c01c 100644 --- a/Sources/DVR/SessionDataTask.swift +++ b/Sources/DVR/SessionDataTask.swift @@ -19,6 +19,10 @@ final class SessionDataTask: URLSessionDataTask { return interaction?.response } + override var currentRequest: URLRequest? { + return request + } + // MARK: - Initializers diff --git a/Tests/DVRTests/SessionTests.swift b/Tests/DVRTests/SessionTests.swift index c961fd4..4ae8de4 100644 --- a/Tests/DVRTests/SessionTests.swift +++ b/Tests/DVRTests/SessionTests.swift @@ -27,6 +27,8 @@ class SessionTests: XCTestCase { } else { XCTFail() } + + XCTAssertEqual(dataTask.currentRequest?.url?.absoluteString, request.url?.absoluteString) } func testDataTaskWithCompletion() {