-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: further trim dependencies #2401
Comments
@matrey We will take a look at it and will implement, understand the importance, and your examples of implementation are helpful. Can you elaborate on your reasons for caring about it from your side? We would like to have a better grasp on users needs. |
We have a list of "pre-approved" open source licenses at work (to make sure we don't inadvertently infringe on some clauses), so I made some scripts that force me to vet any new dependency (by referencing a link to its LICENSE file, which requires me to go look at the source repo for each package). This is how I ended up discovering that 2 dependencies could actually be omitted altogether for the Python version I use (3.11). It's very minor and not a blocker for me, especially compared to #2298 |
I see, thanks for the details! The request seems simple enough to be added to the close release. |
Describe the feature
Once the change from #2298 is released, the deps should be:
This could be further optimized, with
async-timeout
andtyping-extensions
(which is only used so far forSelf
) not being needed for Python 3.11+1/
https://github.com/aio-libs/async-timeout reads:
2/
Looking for
typing_extensions
in the codebase on main, only 1 match came up:valkey-glide/python/python/glide/glide_client.py
Line 30 in 2239c59
Same here, Self is available from typing starting with Python 3.11 so the requirement could be narrowed to
; python_version < "3.11"
Then adapt the code:
Potential approach from https://github.com/SimplyPrint/printer-ws-client/pull/4/files
Potential approach from https://github.com/stac-utils/stac-geoparquet/pull/67/files
Use Case
Less unneeded deps for Python 3.11+
Proposed Solution
No response
Other Information
No response
Acknowledgements
Client version used
1.1.0
Environment details (OS name and version, etc.)
python 3.11 on linux amd64
The text was updated successfully, but these errors were encountered: