Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Generator CMakeLists.txt assumes build artifacts already exist #144

Open
vancemiller opened this issue Jun 2, 2021 · 4 comments
Open
Labels
bug Something isn't working

Comments

@vancemiller
Copy link
Contributor

Describe the bug
Try initializing the cmake build system on a new clone of the repository.

To Reproduce
Try initializing the cmake build system on a new clone of the repository.

cmake -DAVA_GEN_CUDART_SPEC=On -DAVA_MANAGER_LEGACY=On ../ava
# note out of source tree build

Expected behavior
Cmake completes successfully.

Error log

CMake Error at cava/CMakeLists.txt:39 (add_subdirectory):
  add_subdirectory given source "cudart_nw" which is not an existing
  directory.
@vancemiller vancemiller added the bug Something isn't working label Jun 2, 2021
@photoszzt
Copy link
Collaborator

You need to run generate.py first. It needs a better error message to inform the user.

@vancemiller
Copy link
Contributor Author

vancemiller commented Jun 2, 2021 via email

@photoszzt
Copy link
Collaborator

It could be. https://cmake.org/cmake/help/latest/command/execute_process.html But it will make the configure time longer.

@vancemiller
Copy link
Contributor Author

That seems ok. Better to keep the build process as simple as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants