Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TON Connect Payload Issue When Application is Not Running #177

Open
Totemancer opened this issue Aug 13, 2024 · 4 comments
Open

TON Connect Payload Issue When Application is Not Running #177

Totemancer opened this issue Aug 13, 2024 · 4 comments

Comments

@Totemancer
Copy link
Contributor

Hello Tonkeeper Team / @KuznetsovNikita,

We’ve discovered a minor issue. If Tonkeeper Desktop is not running and a wallet is connected to an app—in our case, the Totemancer Telegram Mini App—while preparing a transaction, the app opens fine, but the transaction is not visible for acceptance once the app opens. The transaction payload only works if Tonkeeper Desktop is already running before preparing the transaction.

In contrast, the mobile version of Tonkeeper works perfectly. Perhaps some state handling improvements could be made for the desktop version.

Thank you for your work.

@KuznetsovNikita
Copy link
Collaborator

Hello @Totemancer
I remember this issue, it's a trouble with electron launch parameter
I will take a look on it, at first time I didn't find a solution for it.

Thank you for report!

@77571526
Copy link

تیم Tonkeeper / ،
ما یک مشکل جزئی را کشف کردیم. اگر Tonkeeper Desktop در حال اجرا نباشد و کیف پولی به یک برنامه متصل باشد - در مورد ما، برنامه Totemancer Telegram Mini - هنگام آماده کردن تراکنش، برنامه به خوبی باز می شود، اما پس از باز شدن برنامه، تراکنش برای پذیرش قابل مشاهده نیست. محموله تراکنش فقط در صورتی کار می کند که Tonkeeper Desktop از قبل قبل از آماده سازی تراکنش در حال اجرا باشد.
در مقابل، نسخه موبایل Tonkeeper به خوبی کار می کند. شاید بتوان برای نسخه دسکتاپ بهبودهایی در مدیریت حالت ایجاد کرد.
ممنون از کار شما

@Totemancer
Copy link
Contributor Author

Totemancer commented Aug 16, 2024

Hello @Totemancer I remember this issue, it's a trouble with electron launch parameter I will take a look on it, at first time I didn't find a solution for it.

Thank you for report!

It’s worth mentioning that this likely relates to bridge connection code. (Other issue - might be related)

Example: In the Totemancer Mini App, preparing a transaction makes it appear in the Tonkeeper Desktop App for acceptance.

If we cancel the transaction, the bridge and the Mini App don’t register the cancellation.

However, with the Tonkeeper mobile app, denying the transaction correctly updates both the Mini App and TON Connect about the cancellation.

@Tirmizi106
Copy link

What are you thinking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants