Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code Fix] Reduce code jumps #16

Closed
e6654321 opened this issue Jul 6, 2024 · 2 comments
Closed

[Code Fix] Reduce code jumps #16

e6654321 opened this issue Jul 6, 2024 · 2 comments

Comments

@e6654321
Copy link

e6654321 commented Jul 6, 2024

#15 - Reduce jump commands by removing nested if condition for improved storage and gas

@nns2009
Copy link

nns2009 commented Jul 10, 2024

Have you tested gas reduction?

It looks to me that it will increase gas costs in the "primary case" (signature is correct): your code will go through two conditions (one of which also has &) instead of one

@tolya-yanot
Copy link
Member

At this development stage, optimisations are not longer acceptable; and it is also debatable whether gas consumption will decrease

@tolya-yanot tolya-yanot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants