Skip to content
This repository has been archived by the owner on Dec 12, 2020. It is now read-only.

Priority/Context action sheets no longer display items within iOS 8 #230

Closed
stevendpclark opened this issue Sep 25, 2014 · 8 comments · Fixed by #231
Closed

Priority/Context action sheets no longer display items within iOS 8 #230

stevendpclark opened this issue Sep 25, 2014 · 8 comments · Fixed by #231

Comments

@stevendpclark
Copy link
Contributor

After upgrading to iOS 8, the Priority/Context action sheet pickers fail to work within the edit task screen, nor does the sort action sheet picker work on the main screen.

ios simulator screen shot sep 24 2014 11 24 35 pm

I believe this problem is due to the iOS todo.txt project using an older version of the ActionSheetPicker project. It will need to be updated to use the new forked version.

@kud1ing
Copy link

kud1ing commented Oct 2, 2014

I have this too.

@sukima
Copy link

sukima commented Oct 8, 2014

Same here. Any one got any ideas on what might be the cause? Or perhaps seen something similar in other apps?

@ginatrapani
Copy link
Member

Anyone available to try to upgrade ActionSheetPicker? My first try failed with many build errors.

@chuckbjones
Copy link
Contributor

I've got it almost figured out. A lot of the API changed.

@chuckbjones
Copy link
Contributor

Sent a PR. Only tested on simulators (iPhone 5s and iPad Air). Couldn't figure out how to run unit tests. It looks like the framework we were using is no longer supported?

@ginatrapani
Copy link
Member

Thanks again Chuck! re: testing framework, I upgraded us from OCUnit to XCTest in
13f8cb2

We have some "issues" in the StringsTest but I think they're just a syntax issue.

@stevendpclark
Copy link
Contributor Author

Thanks Chuck for fixing the issue, just didn't have time to get around to it.

I have created a pull request to fix the issues running the unit tests within #232

@sukima
Copy link

sukima commented Oct 21, 2014

I've tested the merge on iOS 8.0 (iPhone 5s) and it works. ✔️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants