Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EntityAliasFilter is not part of EntityFilters #56

Open
skewty opened this issue Nov 4, 2023 · 1 comment
Open

EntityAliasFilter is not part of EntityFilters #56

skewty opened this issue Nov 4, 2023 · 1 comment

Comments

@skewty
Copy link

skewty commented Nov 4, 2023

app/shared/models/alias.models.d.ts

export type EntityFilters = SingleEntityFilter & EntityListFilter & EntityNameFilter & EntityTypeFilter & StateEntityFilter & AssetTypeFilter & DeviceTypeFilter & EdgeTypeFilter & EntityViewFilter & RelationsQueryFilter & AssetSearchQueryFilter & DeviceSearchQueryFilter & EntityViewSearchQueryFilter & EntitySearchQueryFilter & EdgeSearchQueryFilter;

export interface EntityAliasFilter extends EntityFilters {
    type?: AliasFilterType;
    resolveMultiple?: boolean;
}

Notice that EntityAliasFilter is not part of EntityFilters. Is this correct?

@skewty
Copy link
Author

skewty commented Dec 4, 2023

I see some similar type cleanup slated for version 3.6.2 inclusion.
Reference: thingsboard/thingsboard#9010

Will this issue be fixed for 3.6.2 as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant