Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate refresh tokens #161

Closed
enolfc opened this issue Jul 4, 2022 · 2 comments
Closed

deprecate refresh tokens #161

enolfc opened this issue Jul 4, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@enolfc
Copy link
Collaborator

enolfc commented Jul 4, 2022

some time ago the use of refresh tokens + client id + client secret was seen as potentially insecure and oidc-agent was implemented instead. It's been some time since this change, should the use of refresh tokens be deprecated now?
@tdviet
Copy link
Owner

tdviet commented Jul 4, 2022

Yes, surely. We have warned about the planned deprecation more than one year, now is the time to do it: https://github.com/tdviet/fedcloudclient/blob/master/fedcloudclient/checkin.py#L109

The deprecation will require updating documentation and so on. I plan to do it after the holiday season, together with the introduction of configuration file: #86

@tdviet tdviet added the enhancement New feature or request label Jul 4, 2022
@tdviet
Copy link
Owner

tdviet commented Oct 18, 2022

Done in #171

@tdviet tdviet closed this as completed Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@enolfc @tdviet