Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the ContentMetadataInspector #170

Open
alexander-schranz opened this issue Oct 9, 2020 · 0 comments
Open

Refactor the ContentMetadataInspector #170

alexander-schranz opened this issue Oct 9, 2020 · 0 comments
Labels
DX Only affecting the end developer

Comments

@alexander-schranz
Copy link
Member

This should only be done once. Best would be in a compilerpass or of doctrine metadata is not available there (not sure when doctrine load its metadata), we should do it once and as seen in #168 there should be some kind of provider implemented or we need to adjust that the single table inheritance work correctly, which was the use case to make this part override able.

We should avoid that any dev will get into contact with the ContentMetadataInspector it should just work correctly in all cases of doctrine configuration.

@alexander-schranz alexander-schranz added the DX Only affecting the end developer label Oct 9, 2020
@niklasnatter niklasnatter changed the title Refractor the ContentMetadataInspector Refactor the ContentMetadataInspector Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Only affecting the end developer
Projects
None yet
Development

No branches or pull requests

1 participant