Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thumb service: should required params actually be part of routes? #62

Open
ndushay opened this issue Jan 23, 2017 · 0 comments
Open

thumb service: should required params actually be part of routes? #62

ndushay opened this issue Jan 23, 2017 · 0 comments

Comments

@ndushay
Copy link
Contributor

ndushay commented Jan 23, 2017

Given that the routes are:

[was@was-thumbnail-prod current]$ bundle exec rake routes RAILS_ENV=production
          Prefix Verb URI Pattern                                         Controller#Action
      okcomputer      /status                                             OkComputer::Engine
            root GET  /                                                   admin#seeds
      jobs_retry GET  /jobs/retry(.:format)                               jobs#retry
     jobs_remove GET  /jobs/remove(.:format)                              jobs#remove
      admin_jobs GET  /admin/jobs(.:format)                               admin#jobs
     admin_seeds GET  /admin/seeds(.:format)                              admin#seeds
    admin_errors GET  /admin/errors(.:format)                             admin#errors
admin_thumbnails GET  /admin/thumbnails(.:format)                         admin#thumbnails
   api_seed_list GET  /api/seed/list(.:format)                            api/seed#list
 api_seed_create GET  /api/seed/create(.:format)                          api/seed#create
                 GET  /api/v1/was/thumbnails/druid_id/:druid_id(.:format) api/thumbnails#list
                 GET  /api/v1/was/thumbnails/uri(.:format)                api/thumbnails#list

note that the /jobs routes and the admin/thumbnail/ require a parameter ... should it just be part of the route? (there may be other candidates, too)

e.g. admin/thumbnail/:druid vs admin/thumbnail?druid=xxx

@ndushay ndushay changed the title thumb service: are /admin routes any good? thumb service: should /admin/thumbnails route be /admin/thumbnails/:druid_id ? Jan 24, 2017
@ndushay ndushay changed the title thumb service: should /admin/thumbnails route be /admin/thumbnails/:druid_id ? thumb service: should required params actually be part of routes? Jan 24, 2017
@ndushay ndushay removed the bug label Jan 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant