Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for integration with Room, proguard rules are missing in this repository #28

Open
UKMIITB opened this issue Jan 7, 2024 · 4 comments

Comments

@UKMIITB
Copy link

UKMIITB commented Jan 7, 2024

Can you please add documentation for the following in this repository

  1. Integration with room
  2. proguard rules that are required

Also can you elaborate a bit more on External dependencies section of readme.
I am using this dependency for integration with room for encryption. Do I have to carry out the steps posted in External dependencies section before publishing the app ?

@developernotes
Copy link
Member

Hi @UKMIITB,

Thank you for your interest in SQLCipher for Android. We will look into clarifying the documentation around integration with the Room API. Currently we note the library includes a SupportOpenHelperFactory within our migration guide 1. Additionally, we include a sample Room integration within the test suite here 2. In terms of the external dependencies, that is detailed here 3. Our next public release will include ProGuard support. The external dependencies section 4 is only relevant when building sqlcipher-android from source where you would be required to provide an Android-compatible OpenSSL library for linking.

Footnotes

  1. https://www.zetetic.net/sqlcipher/sqlcipher-for-android-migration/#room-api

  2. https://github.com/sqlcipher/sqlcipher-android/blob/master/sqlcipher/src/androidTest/java/net/zetetic/database/sqlcipher_cts/SupportAPIRoomTest.java

  3. https://www.zetetic.net/sqlcipher/sqlcipher-for-android/#community-edition-integration

  4. https://github.com/sqlcipher/sqlcipher-android#external-dependencies

@UKMIITB
Copy link
Author

UKMIITB commented Jan 16, 2024

@developernotes
Just to add one point, System.loadLibrary("sqlcipher") is not much helpful. And it causes crash in some devices with .so file not found exception when we go to production.

What helped us was SplitInstallHelper.loadLibrary(context, "sqlcipher")
Would be good if this part is added in documentation as well

@developernotes
Copy link
Member

Hi @UKMIITB,

Are you deploying your application Android App Bundles by chance?

@UKMIITB
Copy link
Author

UKMIITB commented Jan 17, 2024

@developernotes
Yes we are using aab for deploying.
I think now aab is the recommended way for publishing app on play store

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants