fix #1102: feign-form-spring relocated under io.github.openfeign #1103
+1
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts will need it
|
An alternative could be to leave the explicit dependency on Related: #853 |
OlgaMaciaszek
requested changes
Oct 14, 2024
There was a problem hiding this comment.
Thanks, @DidierLoiseau. Looks good, but could you submit these changes against the 4.1.x branch instead of main, so that they also get included in the 2023.0.x release train?
OlgaMaciaszek
added
dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #1102 and aligns
feign-form-springwith the rest of OpenFeign.Leaving the exclusion forcommons-iofor now since it still has vulnerabilities in versions < 2.14 (See also #1098), which is still a transitive dependency offeign-form-spring:13.5(viacommons-fileupload:1.5).Edit: I just realized that excluding
commons-iobut removing the direct dependency oncommons-fileuploadwill not work for end users, as they actually need the former for the latter.Previously it was still there because of the explicit dependency on
commons-fileupload(the exclusions were a bit useless, actually), and users were getting version 2.11 (with the CVE mentioned in #1098). It will still be the case. The only dependencies that actually change in this PR arefeign-formandfeign-form-spring(checked withdependency:liston the starter module aftermvn install).Note that there is also an explicit dependency on version 2.17, but only with
testscope. You might as well make it a compile-time dependency so that users get the version with the CVE fix…