Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old slab version in dependencies breaks build #131

Open
K0bin opened this issue Oct 3, 2024 · 0 comments · May be fixed by #132
Open

Old slab version in dependencies breaks build #131

K0bin opened this issue Oct 3, 2024 · 0 comments · May be fixed by #132

Comments

@K0bin
Copy link

K0bin commented Oct 3, 2024

async-executor has a dependency on a really old version of slab.

slab = "0.4.4"

The problem is that this version no longer compiles with any remotely recent version of Rust:

error[E0015]: cannot call non-const fn `Slab::<Waker>::new` in constant functions
   --> /home/robin/.cargo/registry/src/index.crates.io-6f17d22bba15001f/async-executor-1.13.1/src/lib.rs:693:32
    |
693 |             active: Mutex::new(Slab::new()),
    |                                ^^^^^^^^^^^
    |
    = note: calls in constant functions are limited to constant functions, tuple structs and tuple variants

This was fixed back in 2022 and shipped with slab 0.4.7.

notgull added a commit that referenced this issue Oct 6, 2024
Closes #131

Signed-off-by: John Nunley <dev@notgull.net>
@notgull notgull linked a pull request Oct 6, 2024 that will close this issue
notgull added a commit to smol-rs/async-io that referenced this issue Oct 6, 2024
cc smol-rs/async-executor#131

Signed-off-by: John Nunley <dev@notgull.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant