Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify coordinate systems for use in electrodes, light, and neurons #28

Open
kjohnsen opened this issue Mar 7, 2023 · 2 comments
Open

Comments

@kjohnsen
Copy link
Member

kjohnsen commented Mar 7, 2023

One module for generating coords, with units.

  • shank coords
  • combining coords
  • repeating coords
  • random cylinders, prisms
  • grid cylinders, prisms
  • assign_coords_to_neurons

Need to decide whether to return x, y, z tuple or nx3 array

@kjohnsen
Copy link
Member Author

kjohnsen commented Nov 2, 2023

coords everywhere should be nx3 array with units

@kjohnsen
Copy link
Member Author

kjohnsen commented Nov 2, 2023

previously:

def assign_coords_uniform_cylinder(
    neuron_group: NeuronGroup,
    xyz_start: Tuple[float, float, float],
    xyz_end: Tuple[float, float, float],
    radius: float,
    unit: Unit = mm,
) -> None:

want to replace assign_... functions with the single assign_coords function and have separate functions to generate coords

def uniform_cylinder(
    n: int,
    xyz_start: Quantity,  # (3,) vector with units
    xyz_end: Quantity,# (3,) vector with units
    radius: Quantity, # e.g., with units
) -> Quantity:  # (n x 3) array with units

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant