Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve splash dialogs #115

Open
Bungeefan opened this issue Mar 7, 2023 · 2 comments
Open

Improve splash dialogs #115

Bungeefan opened this issue Mar 7, 2023 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@Bungeefan
Copy link
Contributor

Bungeefan commented Mar 7, 2023

The current version of our splash dialogs was an improvised solution because of a missing Navigator.
As we now have a navigator since 6f8d628, we could implement proper Dialogs again including Animations.

@Bungeefan Bungeefan added the enhancement New feature or request label Mar 7, 2023
@Bungeefan Bungeefan added this to the 3.0.0 milestone Mar 7, 2023
@Bungeefan Bungeefan self-assigned this Mar 7, 2023
@rjahn
Copy link
Member

rjahn commented Nov 30, 2023

What's the problem without navigator? Some details please.

@Bungeefan
Copy link
Contributor Author

A simple Stack doesn't AFAIK show/allow any animations when inserting a dialog, as these are, at least partly, handled by the respective underlying route that is missing in this case, due to using a stack instead of the navigator.
Using the now existing navigator to display dialogs, would remove this workaround and allow for future animations.

However, as these dialogs are very state driven, it would require some tinkering to introduce reliable navigator dialogs, if possible/useful at all.

@rjahn rjahn modified the milestones: 3.2.0, 3.8.0 Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants