Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a more exhaustive check for submodules #7

Open
player1537 opened this issue Oct 24, 2017 · 0 comments
Open

Add a more exhaustive check for submodules #7

player1537 opened this issue Oct 24, 2017 · 0 comments

Comments

@player1537
Copy link
Collaborator

Right now we do a naive submodule check (if the directory exists, submodules have been pulled in), but we need a better one. When you clone (without --recursive), it still creates the directories, so the script incorrectly assumes they've been pulled in.

An easy fix might be to just always call git submodule update --init, but we'll have to check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant