Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port and IP as shown on flightaware site information #71

Open
mo8Zomo0 opened this issue Mar 13, 2021 · 3 comments
Open

port and IP as shown on flightaware site information #71

mo8Zomo0 opened this issue Mar 13, 2021 · 3 comments
Assignees

Comments

@mo8Zomo0
Copy link

mo8Zomo0 commented Mar 13, 2021

Hi @mikenye &all,

first of all thx for the great work and documentation. I found some minor thing to improve:

https://flightaware.com/adsb/stats/user/ shows the internal IP and port of the local webinterface
under "site information": "Web Interface: View live data (requires local network connection)"
which shows as: http://172.17.0.6:8080/

This is the internal docker IP address or piaware:
docker inspect -f '{{range.NetworkSettings.Networks}}{{.IPAddress}}{{end}}' piaware
172.20.0.6

As I assume that at least the IP is reported from the piaware image somehow, it might be nice if this could get an option,
like default(current behaviour), auto-detect (which could show the main locally routed ip and the correct port (here 8081), or manual, where you can change it to what you want.

@mikenye mikenye self-assigned this Mar 13, 2021
@mikenye
Copy link
Member

mikenye commented Mar 15, 2021

Hi @mo8Zomo0,

I'm not sure I can implement this without making changes to the piaware source code.

Piaware gets the host's IP address by getting the output of the command ip -o address show dev $dev.

It appears to be this section in the piaware source code:
https://github.com/flightaware/piaware/blob/515841346eb6783d1bf9553675aef988fe64748b/package/fa_sysinfo.tcl#L197

There doesn't appear to be a setting that overrides this.

Did you have any thoughts on how we could achieve this outside of modifying the piaware source code?

@mo8Zomo0
Copy link
Author

@mikenye no, not aware how to archive this without patching piaware.
So maybe (as its not really a mikenye issue, but a general docker/piaware issue, I opened a case
towards: flightaware/piaware#70
So lets see.

thx!

@mikenye
Copy link
Member

mikenye commented Mar 22, 2021

PR opened: flightaware/piaware#71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants